Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(editor): Migrate users.store to composition API (no-changelog) #9960

Merged
merged 5 commits into from
Jul 8, 2024
Merged

refactor(editor): Migrate users.store to composition API (no-changelog) #9960

merged 5 commits into from
Jul 8, 2024

Conversation

RicardoE105
Copy link
Contributor

@RicardoE105 RicardoE105 commented Jul 6, 2024 •
edited
Loading

Summary

Title self-explanatory

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@RicardoE105 RicardoE105 changed the title migrate users.store to composition API refactor(editor): Migrate users.store to composition API (no-changelog) Jul 6, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jul 6, 2024
@cypress Cypress
Copy link

cypress bot commented Jul 7, 2024 •
edited
Loading

3 flaky tests on run #5825 ↗︎

0 399 0 0 Flakiness 3

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 RicardoE105 🗃️ e2e/*
Project: n8n Commit: 14f763bfe0
Status: Passed Duration: 05:34 💡
Started: Jul 8, 2024 2:13 PM Ended: Jul 8, 2024 2:19 PM
Flakiness  e2e/5-ndv.cy.ts • 3 flaky tests

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
NDV > should retrieve remote options when non-required params throw errors Screenshots Video
NDV > Stop listening for trigger event from NDV Screenshots Video

Review all test suite changes for PR #9960 ↗︎

alexgrozav
alexgrozav approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@alexgrozav alexgrozav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! 🙌

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024

✅ All Cypress E2E specs passed

@RicardoE105 RicardoE105 merged commit f40f9b0 into master Jul 8, 2024
27 checks passed
@RicardoE105 RicardoE105 deleted the users.store-to-composition-api branch July 8, 2024 14:21
@janober
Copy link
Member

janober commented Jul 10, 2024

Got released with n8n@1.50.0

jeanpaul pushed a commit that referenced this pull request Jul 11, 2024
@RicardoE105 @jeanpaul
refactor(editor): Migrate users.store to composition API (no-change…
ab38f1b 
…log) (#9960)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgrozav alexgrozav alexgrozav approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RicardoE105 @janober @alexgrozav