Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review ParserBase member access modifiers to ensure they match those in hapi. #399

Open
milkshakeuk opened this issue Jan 5, 2023 · 0 comments

Comments

@milkshakeuk
Copy link
Member

Describe the Issue
It's not clear that the access modifiers in the ParserBase and any class that inherits from it are using the correct access modifiers for all its members.

I suspect there are some public members which shouldn't be public, I suspect that during the original porting process looking at the default access modifiers for java wasn't compared to the default access modifiers for C#, since these are slightly different.

This issue is just to review those modifiers to make sure they match - it may mean a change in contract which may mean a major nHapi revision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant