-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SPIDEV driver for Character Device v2 ABI; cache FDs #959
Conversation
2bndy5
commented
Mar 11, 2024
- uses Linux Kernel's Character Device v2 ABI instead of the deprecated v1 ABI
- caches the File Descriptors used to control GPIO pins
show detailed exception msgs
I still want to test the caching of FDs. Specifically,
I'm opening this PR as the solution for #943 will be separate from these changes implemented for non-IRQ GPIO usage. |
close GPIO chip FD when not being used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested everything, but looks like you've been thorough.
Works like a charm!
The new install script with automated selection for branches is prettynice to have now too for testing stuff.
This should allow for easier code reuse when implementing a similar cache for interrupts
I think it would be helpful to have it Anyway. Yeah, I'm ready to merge this and move on to #943. I've been testing it pretty thoroughly (even in my local pyRF24 cloned repo). |
Cool, been running this on all my RPis overnight as well. |