Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small updates #14

Merged
merged 7 commits into from
Jan 19, 2023
Merged

Small updates #14

merged 7 commits into from
Jan 19, 2023

Conversation

2bndy5
Copy link
Member

@2bndy5 2bndy5 commented Jan 19, 2023

More like routine updates...


Most significant change here is the increase of the MAX_PAYLOAD_SIZE to 1514. One can still customize the value by doing a custom build from source using an env var named CMAKE_ARGS

export CMAKE_ARGS="-DMAX_PAYLOAD_SIZE=1514"

or monkeypatch the value at python runtime (not entirely good practice because its technically a module-level "constant" attribute)

import pyrf24
pyrf24.rf24_network.MAX_PAYLOAD_SIZE = 1514

- add missing max/min info to PL_size docstring
- update docs CSS
- fix typos in README and explicitly mention where docs are hosted
- adjust type hint in docstring
- adjust rf24_network stub file
@2bndy5
Copy link
Member Author

2bndy5 commented Jan 19, 2023

This will close #13 since that's where I discovered the lack of payload_size max/min description in the docs.

@2bndy5 2bndy5 linked an issue Jan 19, 2023 that may be closed by this pull request
@2bndy5 2bndy5 merged commit 10eae4d into main Jan 19, 2023
@2bndy5 2bndy5 deleted the small-updates branch January 19, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NRF24 transfer speed
2 participants