Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify all compiled C++ into 1 binary file #64

Merged
merged 5 commits into from
Jun 15, 2024
Merged

unify all compiled C++ into 1 binary file #64

merged 5 commits into from
Jun 15, 2024

Conversation

2bndy5
Copy link
Member

@2bndy5 2bndy5 commented Jun 13, 2024

should resolve #61

@2bndy5 2bndy5 added the bug Something isn't working label Jun 13, 2024
@2bndy5 2bndy5 force-pushed the one-bin-4-all branch 2 times, most recently from 2eb3adf to ad3a336 Compare June 15, 2024 11:18
@2bndy5
Copy link
Member Author

2bndy5 commented Jun 15, 2024

SERIAL_DEBUG is used to enable debug output in both RF24 and RF24Network libs. Because these changes compile both libs into 1 binary, we have no way to independently control which lib outputs debug statements. Both RF24 and RF24Network will output debug statements if we do

export CMAKE_ARGS=-DSERIAL_DEBUG=1
pip install -v .

Previously, I was able to control which lib's debug output is enabled when compiling the libs into separate binaries. I know this isn't a big concern, but the RF24 debug output can be noisy and make it difficult to see/find debug output from RF24Network.

to create sdist for release (and bdist for docs)
@2bndy5 2bndy5 merged commit 628b6c6 into main Jun 15, 2024
3 checks passed
@2bndy5 2bndy5 deleted the one-bin-4-all branch June 16, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RPi Zero - ImportError: libcpp_rf24.so: cannot open shared object file: No such file or directory
1 participant