Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for resolving provider field #25

Merged
merged 5 commits into from
Jul 13, 2024
Merged

Conversation

jfrconley
Copy link
Contributor

Problem

Currently, an exception is thrown when a construct specifies a provider field.

Solution

Fields that contain TerraformResources should be excluded from resolution

Test Plan:

  • Covered by existing tests
  • New coverage added
  • Special instructions for testing described below

Documentation:

  • No documentation required
  • Additional documentation required below

Additional Notes:

N/A

Copy link

changeset-bot bot commented Jun 14, 2024

🦋 Changeset detected

Latest commit: 1f55ae1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@nrfcloud/cdktf-aws-adaptor Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 14, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 83.91% 5425 / 6465
🔵 Statements 83.91% 5425 / 6465
🔵 Functions 70.5% 239 / 339
🔵 Branches 74.19% 486 / 655
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/lib/core/cdk-adaptor-stack.ts 69.82% 79.12% 78% 69.82% 69-71, 94-95, 102-103, 115-116, 132-133, 300-301, 306-307, 316-317, 330-334, 370-375, 406, 421-422, 446-455, 459-466, 472-476, 479-488, 491-504, 510-527, 553-569, 594-597, 612-618, 626-629, 635-638, 650-651, 658-659, 662-663, 666-667, 705-706, 711-713, 716-723, 726-737, 740-745, 748-783, 786-788, 791-799, 802-810, 813-819, 822-828, 831-835, 838-840, 843-850
Generated in workflow #60

@jfrconley jfrconley requested a review from semcc July 9, 2024 20:26
@jfrconley jfrconley merged commit de80613 into main Jul 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants