Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FeatureRequest: compare numbers with a given precision #22

Closed
luigi-bar opened this issue Jun 30, 2015 · 3 comments
Closed

FeatureRequest: compare numbers with a given precision #22

luigi-bar opened this issue Jun 30, 2015 · 3 comments

Comments

@luigi-bar
Copy link

Hi,
this is a great tool, and I would like to use it against some computed files.
Sadly, I get thousand of false errors, like:

DIFF Cell at MyTab!M79 => '979.1358516266992' v/s '979.1358516266946'

Would it be possible to put a threshold when comparing numbers?

Thanks!
Luigi

@na-ka-na
Copy link
Owner

Yes, this is should be doable, I'll take it up for the next release.

On Tue, Jun 30, 2015 at 8:03 AM, luigikitten notifications@github.com
wrote:

Hi,
this is a great tool, and I would like to use it against some computed
files.
Sadly, I get thousand of false errors, like:

DIFF Cell at MyTab!M79 => '979.1358516266992' v/s '979.1358516266946'

Would it be possible to put a threshold when comparing numbers?

Thanks!
Luigi


Reply to this email directly or view it on GitHub
#22.

@na-ka-na
Copy link
Owner

Added a --diff_numeric_precision flag. Released 0.5.0.

@luigi-bar
Copy link
Author

Many thanks!!! I will check it asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants