Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create strings.xml for South Korea #41

Merged
merged 1 commit into from
Dec 9, 2018
Merged

Create strings.xml for South Korea #41

merged 1 commit into from
Dec 9, 2018

Conversation

naXa777
Copy link
Owner

@naXa777 naXa777 commented Dec 7, 2018

No description provided.

@naXa777
Copy link
Owner Author

naXa777 commented Dec 7, 2018

The Travis CI build failed due to unavailable environment variables. It is safe to merge this PR.

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions

@onestone9900
Copy link

The Travis CI build failed due to unavailable environment variables. It is safe to merge this PR.

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions

I read "link URL" and "Travis CI get in start doc" for several days.
I don't know exactly understand problem
In that case, It's not create my Code but miss match upstream Repository because I am external contributor, isn't it?

I study concept of CI. so cool!
Let me know misunderstand or what I should do about this problem~
Have a good day! :)

@naXa777
Copy link
Owner Author

naXa777 commented Dec 9, 2018

@sowen2819 No, there's no action required from you. Sorry for the confusion!

It's just a specific of my project configuration. This Android application requires Crashlytics secret key in order to build properly and I have this key configured in Travis CI environment variable. But for security reasons, some environment variables are hidden (not available) when building pull requests. Therefore the build errored.

It was a surprise for me :) And I will investigate this problem later.

@naXa777 naXa777 merged commit 58f18e0 into naXa777:master Dec 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants