Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix secstohhmm typecast for PHP 8 #1230

Merged
merged 3 commits into from
Jun 8, 2021
Merged

Fix secstohhmm typecast for PHP 8 #1230

merged 3 commits into from
Jun 8, 2021

Conversation

FatihKoz
Copy link
Contributor

@FatihKoz FatihKoz commented Jun 6, 2021

Looks like php8 is not liking numeric strings as we like them.

Fixes #1229

Looks like php8 is not liking numeric strings as we like them.

Fixes #1229
@nabeelio
Copy link
Owner

nabeelio commented Jun 6, 2021

This needs tests for sure

@nabeelio nabeelio added the bug label Jun 6, 2021
@nabeelio nabeelio added this to the 7.0.0 milestone Jun 6, 2021
@FatihKoz
Copy link
Contributor Author

FatihKoz commented Jun 6, 2021 via email

@nabeelio
Copy link
Owner

nabeelio commented Jun 6, 2021

Nothing that is testing that exact method

@FatihKoz
Copy link
Contributor Author

FatihKoz commented Jun 6, 2021

Sure, we need to read $simbrief->xml->times->est_time_enroute from what you have as xml for testing and then check the result.

Test data has 2077 seconds as EET, so it should give a result 0034 as hhmm.

Nothing complicated, if you wish I can try adding a test method for this.

@nabeelio nabeelio merged commit a31201d into nabeelio:dev Jun 8, 2021
@nabeelio nabeelio changed the title Update helpers.php Fix secstohhmm typecast for PHP 8 Jun 8, 2021
@FatihKoz FatihKoz deleted the patch-4 branch June 8, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simbrief rendering errors on PHP 8
2 participants