Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Module Files #843

Merged
merged 10 commits into from
Sep 28, 2020
Merged

Updated Module Files #843

merged 10 commits into from
Sep 28, 2020

Conversation

YashGovekar
Copy link
Contributor

Fixed Module Not Loading Due to Route and RouteServiceProvider Error

@nabeelio nabeelio added the bug label Sep 28, 2020
@nabeelio nabeelio added this to the 7.0.0 milestone Sep 28, 2020
@nabeelio
Copy link
Owner

ref #714

tatus Outdated Show resolved Hide resolved
@nabeelio
Copy link
Owner

The tatus file is still there

@YashGovekar
Copy link
Contributor Author

The tatus file is still there

Hey, which tatus file are we talking about?
Sorry, I dont get it.

@nabeelio
Copy link
Owner

@YashGovekar
Copy link
Contributor Author

Look at the files changed:

https://github.com/nabeelio/phpvms/pull/843/files#diff-a292cf681d24ce485542e442839910a0

Alright done!
Thanks

@nabeelio nabeelio merged commit 2c539d3 into nabeelio:dev Sep 28, 2020
@nabeelio
Copy link
Owner

@YashGovekar thanks for the PR!!

@YashGovekar
Copy link
Contributor Author

@YashGovekar thanks for the PR!!

No problem!
Thanks to you infact. I am a bit new to github commands. So not much aware of them.

@YashGovekar YashGovekar deleted the UPDATE_MODULE_FILES branch September 28, 2020 20:09
@nabeelio
Copy link
Owner

It's a good learning experience :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants