Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Cosmetic Change to Rank & Home Airport Display #852

Merged
merged 5 commits into from
Oct 9, 2020
Merged

Small Cosmetic Change to Rank & Home Airport Display #852

merged 5 commits into from
Oct 9, 2020

Conversation

Da-Geek
Copy link
Contributor

@Da-Geek Da-Geek commented Oct 3, 2020

This cosmetic change is a very small change to 2 items on the Pilot's Profile Page.
1.) Display the Users Rank Image "{{ $user->rank->image_url }}"
2.) also change the Order of the "Home Airport" text and value

This cosmetic change is a very small change to 2 items on the Pilot's Profile Page.
1.) Display the Users Rank Image "{{ $user->rank->image_url }}"
2.) also change the Order of the "Home Airport" text and value
@nabeelio
Copy link
Owner

nabeelio commented Oct 3, 2020

This leaves the rest of the fields displayed as inconsistent, title for one on top, and the rest are below. I'd change this in your own skin, if you could take that bit out. The rank image is fine ok, I forgot to put that in

@nabeelio nabeelio added this to the 7.0.0 milestone Oct 3, 2020
@Da-Geek
Copy link
Contributor Author

Da-Geek commented Oct 3, 2020

This leaves the rest of the fields displayed as inconsistent, title for one on top, and the rest are below. I'd change this in your own skin, if you could take that bit out. The rank image is fine ok, I forgot to put that in

I was thinking of moving the "Flag" next to the Pilot Name, maybe on the Left of the name, Given how small the Flag image is,
so you would have the Avatar/Profile pic, then under that, the Flag & Pilot Name,
then maybe the ID & Airline (as they are on separate lines).
The new Rank Layout with the Image and then Rank Name looks fine with or without an image, and really doesn't need the wording "Rank", as it is very obvious the same as you have no wording for "Pilot ID" or "Airline".
The reason for moving the "Home Airport" Text, it seems to make much more sense to say the "Home Airport is EGKB" rather than "EGKB is the Home Airport"

as suggested by nabeelio, I am moving the Home Airport text back below the Field rather than Above
Da-Geek and others added 2 commits October 6, 2020 23:59
Added change suggested by nabeelio to make the rank img display a conditional
@Da-Geek
Copy link
Contributor Author

Da-Geek commented Oct 9, 2020

Is this PR stuck right now?
Is there anything else you need me to do with this one @nabeelio?

@nabeelio
Copy link
Owner

nabeelio commented Oct 9, 2020

I was busy with some other things. Merging now.

@nabeelio nabeelio merged commit 0a5194b into nabeelio:dev Oct 9, 2020
@Da-Geek Da-Geek deleted the patch-1 branch October 9, 2020 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants