Fix sslyze crash on some domains in nassl handshake #108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes two blocking errors in nassl that occur when running sslyze on certain domain names.
When the "last octet invalid" and "bad signature" errors occur together, or when the "first octet invalid" and "bad signature" errors occur together, the thread stops and the SoftTimeLimitExceeded error is thrown on our threads.
I have forked the project and made the necessary change to fix these errors.
These changes should prevent the blocking errors from occurring and allow sslyze to run successfully on certain domain names. I have tested these changes locally and they appear to be working as expected.