Specify the garbage collector as the CMS #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paderlol please help to review. |
wilsonwu
reviewed
Apr 22, 2023
build/bin/docker-startup.sh
Outdated
Comment on lines
34
to
36
| JAVA_OPT="${JAVA_OPT} -XX:+UseConcMarkSweepGC -XX:+UseCMSCompactAtFullCollection -XX:CMSInitiatingOccupancyFraction=70 -XX:+CMSParallelRemarkEnabled -XX:SoftRefLRUPolicyMSPerMB=0 -XX:+CMSClassUnloadingEnabled -XX:SurvivorRatio=8 -XX:-UseParNewGC" | ||
| JAVA_OPT="${JAVA_OPT} -Xms${JVM_XMS} -Xmx${JVM_XMX} -Xmn${JVM_XMN}" | ||
| JAVA_OPT="${JAVA_OPT} -Dnacos.standalone=true" |
There was a problem hiding this comment.
Could you please keep same indent, thanks.
There was a problem hiding this comment.
Oh，that's too bad. I fix it.
There was a problem hiding this comment.
I looked at it again.I didn't mean to write on that line.so bad. Dockerfile based on jdk8，I want to specify this parameter for both standalone and other
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 .Refer to this alibaba/nacos#10343
2.Fix README format error about MYSQL_SERVICE_DB_PARAM row