Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: random index for load balance the server list. #164

Merged
merged 1 commit into from
May 22, 2023

Conversation

CherishCai
Copy link
Collaborator

No description provided.

@CherishCai CherishCai added the chore Chore for code label May 22, 2023
@CherishCai CherishCai added this to the 0.3.0 milestone May 22, 2023
@CherishCai CherishCai requested a review from onewe May 22, 2023 03:02
@CherishCai CherishCai self-assigned this May 22, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (2235aae) 8.94% compared to head (768e5b3) 8.94%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #164      +/-   ##
========================================
- Coverage   8.94%   8.94%   -0.01%     
========================================
  Files         49      49              
  Lines       2739    2740       +1     
========================================
  Hits         245     245              
- Misses      2494    2495       +1     
Impacted Files Coverage Δ
src/common/remote/grpc/server_list_service.rs 43.24% <0.00%> (-1.21%) ⬇️
src/naming/mod.rs 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@onewe
Copy link
Collaborator

onewe commented May 22, 2023

我建议 新开一个模块 里面放 server_list 的各种实现, 不直接在 PollingServerListService 中改

@CherishCai
Copy link
Collaborator Author

我建议 新开一个模块 里面放 server_list 的各种实现, 不直接在 PollingServerListService 中改

会不会比较复杂?不过未来支持 server-list-endpoint 确实可以这样搞。

@onewe
Copy link
Collaborator

onewe commented May 22, 2023

LGTM

@onewe onewe merged commit e7ed7b3 into main May 22, 2023
@CherishCai CherishCai deleted the chore_random_index_serverlist branch May 23, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore for code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants