Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: auth by http login do not use lock. #165

Merged
merged 1 commit into from
May 23, 2023
Merged

Conversation

CherishCai
Copy link
Collaborator

No description provided.

@CherishCai CherishCai added the chore Chore for code label May 23, 2023
@CherishCai CherishCai added this to the 0.3.0 milestone May 23, 2023
@CherishCai CherishCai requested a review from onewe May 23, 2023 04:56
@CherishCai CherishCai self-assigned this May 23, 2023
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (e7ed7b3) 8.94% compared to head (af40415) 8.94%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #165   +/-   ##
=====================================
  Coverage   8.94%   8.94%           
=====================================
  Files         49      49           
  Lines       2740    2740           
=====================================
  Hits         245     245           
  Misses      2495    2495           
Impacted Files Coverage Δ
src/api/plugin/auth/auth_by_http.rs 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@onewe
Copy link
Collaborator

onewe commented May 23, 2023

LGTM

@onewe onewe merged commit 0d7df2a into main May 23, 2023
@CherishCai CherishCai deleted the chore_auth_login_nolock branch May 23, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore for code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants