Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: naming_load_cache_at_start=false #218

Merged
merged 3 commits into from
Mar 10, 2024
Merged

Conversation

CherishCai
Copy link
Collaborator

@CherishCai CherishCai added the chore Chore for code label Mar 9, 2024
@CherishCai CherishCai requested a review from onewe March 9, 2024 09:00
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 26.31579% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 15.39%. Comparing base (cf3aa5c) to head (cfe3cfb).

Files Patch % Lines
src/api/props.rs 0.00% 7 Missing ⚠️
src/naming/updater/mod.rs 0.00% 3 Missing ⚠️
src/config/worker.rs 0.00% 2 Missing ⚠️
src/common/cache/mod.rs 83.33% 1 Missing ⚠️
src/naming/mod.rs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
- Coverage   15.46%   15.39%   -0.07%     
==========================================
  Files          51       51              
  Lines        2956     2968      +12     
==========================================
  Hits          457      457              
- Misses       2499     2511      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@onewe onewe merged commit 960104b into main Mar 10, 2024
5 checks passed
@CherishCai CherishCai deleted the chore_naming_load_cache_at_start branch May 16, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore for code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants