Add Configurable Max Retries for get_config in ConfigService #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
CherishCai
reviewed
Aug 12, 2024
src/api/props.rs
Outdated
| @@ -26,6 +26,8 @@ pub struct ClientProps { | |||
| client_version: String, | |||
| /// auth context | |||
| auth_context: HashMap<String, String>, | |||
| /// max retries | |||
| max_retries: Option<i32>, | |||
There was a problem hiding this comment.
次数肯定非负，考虑 u32 ？与 retry_count 一同修改
There was a problem hiding this comment.
👌 retry_count 我一起改为 u32
CherishCai
reviewed
Aug 12, 2024
| @@ -480,6 +483,13 @@ where | |||
| debug_span!(parent: None, "grpc_connection", id = self.id.clone()).entered(); | |||
|
|
|||
| loop { | |||
| if let Some(max_retries) = self.max_retries { | |||
| if self.retry_count >= max_retries { | |||
There was a problem hiding this comment.
这里是提前判断了，很可能需要的是 self.retry_count > max_retries ，比如 max_retries=1 时，应该有一次重试的机会。max_retries=0 才不回有任何重试
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to address the issue described in #241, where the get_config method in ConfigService blocks the main thread if the connection to the configuration server fails. The main issue arises from NacosGrpcConnection’s poll_ready method, which continuously retries without a limit.
Changes Introduced:
Rationale:
Implementing a maximum retries limit offers greater control over service initialization, ensuring that services are not indefinitely blocked by failed attempts to fetch remote configurations.