-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix-el8-crash #73
fix-el8-crash #73
Conversation
Hi @pbiering, Starting to work through these (slowly). Thanks again for sending in the patches. For this one, I can replicate the exact issue when installing from the repos, but for some reason, not when I am compiling the 1.2.0 release from source myself. Did you manage to replicate the issue when building from source, too? Wonder if there are some gcc/glibc changes which are triggering this issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In any case, it makes sense to exit the function early if there are just one entry anyway, so lets merge it. Although I am not 100% sure this is not related to some weird compiler shenanigans/glibc :-)
Merged here: 341eccc Thanks for the PR, I will try to get around to the rest tomorrow! |
Haven' tested because target is stability on EL8
as also compiled with "clang" has not bring up the issue I assume either huge code optimization or additional security mechanism inserted during compilation with gcc |
I tested the new daily build (https://build.opensuse.org/package/binaries/home:naemon:daily/naemon-livestatus/CentOS_8_Stream) and it seems to work fine, so that's great news. Thanks again for the PR! |
split-out to dedicated patch only