Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it suitable for third party app to use online demo's api? #190

Open
neoFelhz opened this issue Jul 14, 2017 · 73 comments
Open

Is it suitable for third party app to use online demo's api? #190

neoFelhz opened this issue Jul 14, 2017 · 73 comments

Comments

@neoFelhz
Copy link

neoFelhz commented Jul 14, 2017

There's a Chinese Android APP using waifu2x online demo's API. And he adds some AD to his APP so that he can make money from it.

Here is the link of the APP: 图片放大镜-拯救马赛克 3.1
And there is the result of packets capture:

And there is the developer's reply to people's question about it:

Translations: Why a software should not have a little bit of profit? I do use someone else's server, and so what? Is it illegal? Why are some people always pretending to be the spokesperson of justice?

There're some information about the APP:

  • Name: 图片放大镜-拯救马赛克
  • Package Name: com.bzy.tpxf
  • Developer: bzyapp
@nagadomi
Copy link
Owner

I know that some addons/scripts are using our API.
waifu2x is an open source project, it can be easily clone it, so I think that they should host their own server.
Also, our server is currently hosted by pixiv Inc. That is probably not what they intend. @edvakf

I am planning to use reCAPTCHA, but one concern is that Chinese users can not access reCAPTCHA because reCAPTCHA is hosted by Google. I've heard that. Is this true?

@neoFelhz
Copy link
Author

neoFelhz commented Jul 14, 2017

@nagadomi Yes, it is true.
I am from China, and I have to use proxy server to access the blocked sites. You can find out more details about GFW at wikipedia: https://en.wikipedia.org/wiki/Great_Firewall
The reCAPTCHA can't work correctly because the GFW blocked nearly all the Servers of Google.
But there are some captcha program which can be self-hosted. Maybe you can use them to avoid the abuse.

@neoFelhz
Copy link
Author

neoFelhz commented Jul 14, 2017

On the other hand, most of abuse may come from China (I am sorry for that if it is true).
Some Chinese like abuse free service, so waifu2x.udp.jp would avoid most of abuse if you decide to use reCAPTCHA.

@wx40217
Copy link

wx40217 commented Jul 15, 2017

What is worse is that he add ADs to his APP to earn money.He never thinks he is wrong and still laughes at people who says he copied others'work.

@zunpiau
Copy link

zunpiau commented Jul 15, 2017

The developer will never stop his behavior unless you add some limit like reCAPTCHA.

@aikachoco
Copy link

@nagadomi
I am another developer from china and I have something to say.
In china , many people pack open source program into apps and add ads in it to earn money.
AND WE DEVELOPERS HATE THEM.
Now this app even advertises itself on other big sites and get more and more users which can cause huge server pressure , so please consider taking fireback such as reCaptcha quickly , really thanks.

btw I want to ask if it is legal to port this project to android platform and make an app for it(which all compute will be done using SOC not remotely)

@nagadomi
Copy link
Owner

@aikachoco
waifu2x is licensed under MIT License. You can use this code for any commercial service. However, we are not allowed to use our web server directly. GPU instance is very costly.

@neoFelhz
Copy link
Author

@nagadomi
And all in all, we all think it is necessary for waifu2x.udp.jp using reCAPTCHA. It can avoid most of the abuse from China.

@nagadomi
Copy link
Owner

I am not thinking of blocking access from certain region.
I just want to avoid high frequency continuous access and external use.

@TigerBeanst
Copy link

@nagadomi.
So I think add reCAPTCHA is a way to avoid the thief like bzyapp

@aikachoco
Copy link

@nagadomi
🤔 so it means I could develop a version which uses chipset from the phone to compute and not use the server?(if I make the source code public too)
Because I made it work on my MI5 before(of course with looooooow speed)

and for captcha...
well after some negociation(i donot remember if the word spells like this), the developer seems not to take back his app.......
Actually I and many other people here know how to bypass the GFW and do the reCAPTCHA xD
and I think people who need the server also know how to do that
so it actually doesnot block a specific country,it just blocks specific people with harmful intent
therefore i still recommend using reCAPTCHA as quickly as possible to block too much heavy traffic by the app

appriciate for answering so quickly

@nagadomi
Copy link
Owner

nagadomi commented Jul 18, 2017

@aikachoco

so it means I could develop a version which uses chipset from the phone to compute and not use the server?

Yes. Also, If you host the your own server, there is nothing wrong.
And, android native app already exists at
https://play.google.com/store/apps/details?id=com.kaede_software.superresolutionwaifu2x&hl=ja
But it uses the old version of waifu2x model.

@nagadomi
Copy link
Owner

I've investigated the access log today.
There are lots of external use, over 50% of POST request was external use.
Currently some UserAgent is blocked, but I guess that they will use fake UserAgent.
Probably we need some additional action.

@neoFelhz
Copy link
Author

@nagadomi
I strongly recommend using reCAPTCHA to avoid most of the abusement.
Another idea is to limit the rate of frequency of the API request.

@MarkussLugia
Copy link

@nagadomi
The developer updated his app about seven hrs ago.
screenshot_20170728-184445
Which is again, capable of using the demo's API.
screenshot_20170728-184429
With someone told him about the UA-blockage, I suppose the apps using fake UA, as you expected. So please do something. Quick.

@nagadomi
Copy link
Owner

nagadomi commented Jul 29, 2017

hmm. now waifu2x.udp.jp have supported reCAPTCHA but I don't like reCAPTCHA, the quiz is very frustrating.
also, currently we are using the google's server, it may not be accessible from china.
I'm going to test the solution with reverse proxy.

@MarkussLugia
Copy link

reCAPTCHA is recommended. For the ones who really interests in how waifu2x works, accessing blocked sites is a piece of cake. It blocks most of the ones who just makes nonsense out of the demo.
P. S. Google-hosted-third-party servers ARE ACCESSABLE in China. Thanks GFW, which blocks sites mainly by DNS corruption.

@flaksp
Copy link

flaksp commented Jul 29, 2017

waifu2x is an open source project, it can be easily clone it, so I think that they should host their own server

You are right, @nagadomi, but servers with GPU are too expensive. For small non-profit projects like mine (which made just 6-12 requests to waifu2x.udp.jp per day) it's impossible to pay $700/mo (lowest price I found on OVH) just for GPU which will be used only in one hobby project.

It will be awesome if you'll release some solutions for non-profit or small projects. Limited API, for example. Or at least any paid plans.

@nagadomi
Copy link
Owner

nagadomi commented Jul 29, 2017

@Ssimplix
My position is the same as you. I am paying $600~$900/mo for free web service from my personal expenses.
The number of GPU instance is chosen by the page view of my web service. There are no free resources.
(currently the server is not hosted by pixiv.)

EDIT:
The application that is descriped by OP is sending a lot of requests to my server.
I am not interested in the business of rental API , so I decided to prohibit external use uniformly.

@Mikoto10032
Copy link

I think that guy just like S.H.I.T.I hasn't official permission.

@Incisakura
Copy link

It seems that the app can't be found in Coolapk.I also hate this people very much.
What a cheerful news.THANS ,OP
And I found a lot of Coolapk Gays.

screenshot_20170731-131838

@Signum1
Copy link

Signum1 commented Jul 31, 2017

@nagadomi I thank you for waifu2x, a very useful tool. I just noticed the captcha and it is not a problem. Abuse of services can ruin it for all, so I'm glad you found a way to stop this without closing it down.

@KatouMegumi-osu
Copy link

Just saying! Captcha is an awesome addition! Now I don't have to wait 8 minutes to process one picture.

1 similar comment
@18701651336
Copy link

Just saying! Captcha is an awesome addition! Now I don't have to wait 8 minutes to process one picture.

@NARKOZ
Copy link

NARKOZ commented Jul 31, 2017

@nagadomi why not to introduce rate limiting instead of captcha?

You can allow only a certain number of requests per day from an IP, and I'm sure 10-20 requests per day will be sufficient for most users.

@nagadomi
Copy link
Owner

nagadomi commented Jul 31, 2017

@nagadomi why not to introduce rate limiting instead of captcha?

It has already activated. 10req/min.
Android app run on the client side, so it can not be regulated by IP rate limits. That app has lots of users.

@KamillaPup
Copy link

I have noticed processing is much faster! Thank you. I installed the code on my Mac, but it is so slow! Pixiv servers are much better.

@hedw1gP
Copy link

hedw1gP commented Aug 2, 2017

However, reCaptcha is not able to use in China Mainland, that means each time Chinese use waifu2x online demo, they have to use VPN in order to touch that I am not a robot, which makes painful

@bibop87
Copy link

bibop87 commented Aug 2, 2017

Hi guys, I understand why reCaptcha is needed, but can you make it so that it does not get complicated every time? Through the pictures 10 it starts to rage and offer to solve on 5 variants with road signs \ cars \ shop-windows, etc. For the text, sorry, google translate

@oniyakun
Copy link

oniyakun commented Aug 2, 2017

I hate people who steal your API. I come from China and I think it's great for the verification code you mentioned, but I didn't see any verification code when I opened the website, and I can't use it. Is there any restriction on Chinese users?

@luckydonald
Copy link

How about adding a watermark if the recaptcha was not filled out (the apps don't know that field), so make them aware of the original website they are using?

@fzq12345
Copy link

fzq12345 commented Aug 4, 2017

ycwei982 ,Can access, that is waifu2x download option did not respond.

@Lakr233
Copy link

Lakr233 commented Aug 4, 2017

In fact, AI process require REALLY HIGH CPU and GPU performance that is expensive to build. The software website is a way to get it done easily via service computer that may include thousands video cards. Too much users may be a disaster to those computers. Also it is not support for you to make money.

@littlebear12
Copy link

ok

@TaihouKai
Copy link

Well, I fully support and understand your action... but reCap is blocked by The Great Firewall in China... :(

@oniyakun
Copy link

oniyakun commented Aug 6, 2017

I found a website similar to waifu2x
http://www.bigjpg.com/
I think is very weird.
If I say something wrong please don't hit me_(:3」∠)_

@MarkussLugia
Copy link

@oniya123 waifu2x uses MIT licence and is free for any commercial use.

@nagadomi
Copy link
Owner

nagadomi commented Aug 6, 2017

@TaihouKai

Well, I fully support and understand your action... but reCap is blocked by The Great Firewall in China... :(

I think it has already solved.
Is it wrong? @ycwei982 and @fzq12345 reported to me that they can access waifu2x.udp.jp.

@nagadomi
Copy link
Owner

nagadomi commented Aug 6, 2017

waifu2x uses MIT licence and is free for any commercial use.

Note that waifu2x is licensed under MIT License but Hatsune Miku image is licensed under CC BY-NC (Attribution-NonCommercial). See NOTICE.

@hedw1gP
Copy link

hedw1gP commented Aug 6, 2017

It is working on 2 cellular networks: (sorry the picture is nuked without any reason, but it works on China Telecom and China Unicom, I don’t have a China Mobile SIM)

pic

@Lakr233
Copy link

Lakr233 commented Aug 7, 2017

China’s Great Fire Wall 2333333333333

@Lakr233
Copy link

Lakr233 commented Aug 7, 2017

It works on China Mobile.

@fzq12345
Copy link

fzq12345 commented Aug 9, 2017

@nagadomi Can be accessed and used normally

@Lakr233
Copy link

Lakr233 commented Aug 9, 2017

17.8.8,23:30 it says “internal server error.”

@Jaynator495
Copy link

Here's a possible solution, Instead of using the API for the web based requests, Use the same page, then make the API have a API key, and if someone wants a 3rd party app or something like that, they can send you a inquiry about getting a API key. Just a thought.

@Lakr233
Copy link

Lakr233 commented Aug 11, 2017

They may use it like AutoFill on safari. Key is not enough.

@NyanMeow
Copy link

丢人丢到国外去了..

@hedw1gP
Copy link

hedw1gP commented Aug 15, 2017

maybe paid API keys in the future can solve this?

@nagadomi
Copy link
Owner

nagadomi commented Aug 15, 2017

I won't provide paid API, but it is possible for someone to do it.

@cia48621793
Copy link

This is the reason you the author should ban all incoming requests from China for the demo server: They like to ABUSE public services and would CIRCUM all the restrictions placed in front of them no matter what. For worse, they like to accuse the others why bother giving a fuck, criticising that it would be a huge waste if all those public services were left unused, they say they are doing it for the greater good, they see themselves as a fucking messiah, even if it means monetizing from services that comes for free to everybody, that's why it is disgusting to me: they defended their acts like it was rightful, while still being a bandit and a thug.

As a Chinese myself, I'm sorry of what my fellow countrymen did to waifu2x and pixiv.

@SCLeoX
Copy link

SCLeoX commented Aug 24, 2017

@cia48621793 Yes, of course! As you said, every Chinese person is despicable. Their behaviors are totally caused by the fact that they are born in China. No matter what they do, they were, are, and will continue to be contemptible. Does that really sounds right?

In your argument you are claiming those thieves think they are messiah, but in fact, it sounds like you
are claiming that yourself is messiah. It seems that you totally understand every single person in China and able to criticize all Chinese people just because one of them did a shameful thing. But you are wrong, you know nothing.

It is certain that this single developer's behavior it is totally unacceptable but how did you come to the conclusion that all Chinese people will do so? If your logic works, then the existence of any prostitute would prove that your mother is prostitute.

It is people like you, who love to slander their countrymen, made foreign people to think Chinese people are generally immoral.

People who should be condemned do exist in China but they exist not because they are Chinese. Some people just born to be selfish. These bad people are scattered in the world. They live not only in China, but also in America, in Canada, in Australia, or in any country you can name of. The difference is that when a American person who live in China did something terrible, you will say it is because this American person lives in a bad environment while if some Chinese person did something awful in America, you will claim it is because this person is born in China. It is clear that the reason for this phenomenon to happen is that the spectator is biased. But sadly, this spectator himself is Chinese.

最后引用一下上面那个人的一句话:像你这种人,才是丢人丢到国外去了..

@nagadomi
Copy link
Owner

I will never block access from a specific area collectively, don't worry about it.

@NatoBoram
Copy link

I agree that you should use ReCaptcha to prevent abuse. However, maybe you can try the Invisible ReCaptcha?

@NekoTony
Copy link

What's the api details?

@NanoAi
Copy link

NanoAi commented Sep 27, 2017

Can we have the ReCaptcha come up initially then save a limited time session so that we don't have to enter the captcha for every single image?

Also how about API Keys?

@Britey
Copy link

Britey commented Oct 3, 2017

My reCAPTCHA somehow works fine with out a vpn inside of china, but i use the caffe offline version anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests