Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookstore: initialize project with components #1

Merged
merged 12 commits into from
Nov 4, 2022

Conversation

NahnahAJ
Copy link
Owner

@NahnahAJ NahnahAJ commented Nov 4, 2022

Project Requirements

  • Initialise React app.
  • The building blocks of your app should be set as re-usable components. Create a directory for your components.
  • Add React Router and set two Routes and Links for the app's navigation:
  • Books - the default view:
  • Should display the list of books (empty at this point but it should be ready for the data) with the Remove button (no functionality yet).
  • Create a component called Book for displaying a single book (receive a title and an author as prop) and reuse it in a component that displays a list of books.
  • Should display a form for adding a book (no functionality yet).
  • Create a separate component for this form (with inputs for a title and an author [IMPORTANT in the design you can see an input for a category - please replace it with an author.]).
  • Categories:
  • Should display a button "Check status" only.
  • No styling required at this point.

Copy link

@1GORDON 1GORDON left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status: APPROVED 🟢

Hi @NahnahAJ

Your project is complete! There is nothing else to say other than... it's time to merge it: ship it:
Congratulations! 🎉 👏 👏 💯

Highlights!

  • Followed Gitflow ✔️
  • Good commit messages ✔️
  • Linters are passing ✔️
  • Descriptive Pull request ✔️
  • Professional readme ✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you consider them as they can improve your code.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread and tag me @1GORDON if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.

@NahnahAJ NahnahAJ merged commit 5424c0a into develop Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants