Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.1.0 still not compatible with Angular 17 #33

Open
whyboris opened this issue Jan 1, 2024 · 3 comments
Open

Release 1.1.0 still not compatible with Angular 17 #33

whyboris opened this issue Jan 1, 2024 · 3 comments
Assignees

Comments

@whyboris
Copy link
Contributor

whyboris commented Jan 1, 2024

❤️ Thank you for updating your repository to work with Angular 17 🚀
😓 unfortunately the published npm package (version 1.1.0) fails installation into an Angular 17 project:

npm ERR! peer @angular/common@">= 6.0.0 < 9.0.6" from an-qrcode@1.1.0
npm ERR! node_modules/an-qrcode
npm ERR!   an-qrcode@"1.1.0" from the root project

I think the fix is easy, so I created a PR: #32

The fix:

"peerDependencies": {
    "@angular/common": ">= 6.0.0 < 18.0.0",
@whyboris
Copy link
Contributor Author

whyboris commented Jan 3, 2024

Thank you for publishing the bugfix version 🥳

😓 unfortunately I think the npm release has missing files:

https://www.npmjs.com/package/an-qrcode/v/1.1.2?activeTab=code

Compare with this release:

https://www.npmjs.com/package/an-qrcode/v/1.0.7?activeTab=code

The package.json commands node to find these files (which are absent from the latest release)

  "main": "bundles/an-qrcode.umd.js",
  "module": "fesm5/an-qrcode.js",

I don't know how your build system works, but I'm happy to try to help if you need a hand 😊 🤝 😁

@whyboris
Copy link
Contributor Author

whyboris commented Jan 13, 2024

Looks like the build command that should work is: ng build an-qrcode

It errors out because of a missing file: "extends": "../../tsconfig.base.json", see: https://github.com/naimmalek/an-qrcode/blob/master/projects/an-qrcode/tsconfig.lib.json#L2

But pointing it to ./tsconfig.json creates a new error I can't get past:

✔ Compiling with Angular sources in Ivy full compilation mode.
✖ Generating FESM bundles
Could not load C:\Code\temp\an-qrcode\src\assets\index.js (imported by dist/an-qrcode/esm2022/lib/an-qrcode.component.mjs): 
Could not load 'C:\Code\temp\an-qrcode\src\assets\index.js' from memory.

Perhaps you know what to do? 🤞

@naimmalek
Copy link
Owner

naimmalek commented Jun 27, 2024

Looks like the build command that should work is: ng build an-qrcode

It errors out because of a missing file: "extends": "../../tsconfig.base.json", see: https://github.com/naimmalek/an-qrcode/blob/master/projects/an-qrcode/tsconfig.lib.json#L2

But pointing it to ./tsconfig.json creates a new error I can't get past:

✔ Compiling with Angular sources in Ivy full compilation mode.
✖ Generating FESM bundles
Could not load C:\Code\temp\an-qrcode\src\assets\index.js (imported by dist/an-qrcode/esm2022/lib/an-qrcode.component.mjs): 
Could not load 'C:\Code\temp\an-qrcode\src\assets\index.js' from memory.

Perhaps you know what to do? 🤞

Didn't get the chance to work on this, can you please create a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants