Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Micro-cleanup #32

Merged
merged 4 commits into from
Jan 3, 2024
Merged

Micro-cleanup #32

merged 4 commits into from
Jan 3, 2024

Conversation

whyboris
Copy link
Contributor

@whyboris whyboris commented Jan 1, 2024

❤️ Thank you for updating your repository to work with Angular 17 🚀

The PR is:

  • minor formatting fixes for the README files
  • a micro-fix for a single unit test (string expectation update)
  • bumping of versions to make the next release compatible with Angular 17 🤞

I tried to fix up unit tests to run without error, but I still get this error:

Error during loading: Uncaught SyntaxError: Unexpected token 'export' in http://localhost:9876/_karma_webpack_/scripts.js line 698

I think with updates to the package.json of the projects/an-qrcode the npm package will start working with Angular 17 🤞

The fix:

  "peerDependencies": {
    "@angular/common": ">= 6.0.0 < 18.0.0",

"peerDependencies": {
"@angular/common": ">= 6.0.0 < 9.0.6",
"@angular/core": ">= 6.0.0 < 9.0.6"
"@angular/common": ">= 6.0.0 < 18.0.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure how things work around here, but it seems like if you insist on having a maximum version you'll forever play catchup, needing to publish a new release every time a new major Angular version comes out 🤔

Perhaps you can remove the maximum version 🤷 - I wish I knew better how it all worked 🤝

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you are correct. Please remove max version from here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ removed 🪓 😁

@naimmalek naimmalek merged commit 416caf0 into naimmalek:master Jan 3, 2024
@whyboris whyboris deleted the cleanup branch January 5, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants