Do not hardcode paths to Authors, Archives, Categories, Tags #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use AUTHORS_URL, ARCHIVES_URL, CATEGORIES_URL, TAGS_URL instead.
sio
added a commit
to sio/pelican-alchemy
that referenced
this pull request
Oct 22, 2019
Non-hardcoded paths are not that simple. Direct templates do not always have meaningful *_URL or even *_SAVE_AS values. More than that, those variables are not even defined by default. Therefore we need to replicate the logic used by Pelican itself when calculating the path to direct template output. Related: - DIRECT_TEMPLATES handling by Pelican: https://github.com/getpelican/pelican/blob/01eb08c42b543450ee5e0e3de3854526708a6711/pelican/generators.py#L537-L550 - Pelican issue for "Why are CATEGORIES_URL and TAGS_URL gone?" getpelican/pelican#1225 Merges nairobilug#75
|
Thank you for this improvement! I've added support for some edge cases and merged this into |
brodul
pushed a commit
to brodul/pelican-alchemy
that referenced
this pull request
May 22, 2020
Non-hardcoded paths are not that simple. Direct templates do not always have meaningful *_URL or even *_SAVE_AS values. More than that, those variables are not even defined by default. Therefore we need to replicate the logic used by Pelican itself when calculating the path to direct template output. Related: - DIRECT_TEMPLATES handling by Pelican: https://github.com/getpelican/pelican/blob/01eb08c42b543450ee5e0e3de3854526708a6711/pelican/generators.py#L537-L550 - Pelican issue for "Why are CATEGORIES_URL and TAGS_URL gone?" getpelican/pelican#1225 Merges nairobilug#75
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use AUTHORS_URL, ARCHIVES_URL, CATEGORIES_URL, TAGS_URL instead.