Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare client services for instrumentation #339

Closed
sechmann opened this issue Nov 21, 2023 · 1 comment
Closed

Prepare client services for instrumentation #339

sechmann opened this issue Nov 21, 2023 · 1 comment

Comments

@sechmann
Copy link
Contributor

The device-{helper,agent,systray} services lack instrumentation. The only way we can debug issues related to these is to ask developers to send us logs.

Consider instrumenting these services using OTEL

https://grafana.com/docs/opentelemetry/instrumentation/go/manual-instrumentation/
https://doc.nais.io/observability/frontend/

We will also have to keep privacy in mind while adding this.

This task should be limited to getting the reporting part working, and a few example measurements. Full instrumentation will have to be achieved over time.

@mortenlj
Copy link
Contributor

I think we would want to collect naisdevice telemetry from all tenants, and if so, we can't use the telemetry.nav.no endpoint that exists for NAV.
We would need to set up a separate endpoint for naisdevice clients.
We should probably also make it possible to pass the endpoint to the clients, so that we can change the endpoint without releasing a new version, and also to make it possible to use a development endpoint when we are developing naisdevice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants