Mimic how jquery handles array parameters with GET #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demersus
force-pushed
the
get-data-array-syntax
branch
from
2761c59
to
e1e56a7
Compare
|
can we merge this PR and publish a new npm version soon? Ember-fastboot really needs this fix for the coalesceFindRequests behavior. |
|
Thanks for the pr! Sorry for just getting round to this |
|
thank you for the fix! I'm creating a fork of ember-fastboot now to investigate if this fixes our problem. |
|
Not a problem, Thanks for merging. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered this behaving differently than jQuery while using Ember Fastboot.
This PR allows arrays to be serialized the same way $.param does:
{a: [1,2,3]}becomes?a[]=1&a[]=2&a[]=3The old way:
?a[0]=1&a[1]=2&a[2]=3