Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix insecure generation of random numbers #108

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Conversation

nakabonne
Copy link
Owner

The miekg/dns package before 1.1.25 improperly generates random numbers because math/rand is used. The TXID becomes predictable, leading to response forgeries.

See: GHSA-44r7-7p62-q3fr

@codecov-commenter
Copy link

Codecov Report

Merging #108 (5327a50) into master (78c80a0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #108   +/-   ##
=======================================
  Coverage   62.30%   62.30%           
=======================================
  Files          11       11           
  Lines         716      716           
=======================================
  Hits          446      446           
  Misses        235      235           
  Partials       35       35           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78c80a0...5327a50. Read the comment docs.

@nakabonne nakabonne merged commit 3f74a81 into master Jul 27, 2021
@nakabonne nakabonne deleted the fix-cve-2019-19794 branch July 27, 2021 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants