Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race contition in drawer.redrawMetrics() #115

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

fedorlitau
Copy link
Contributor

@fedorlitau fedorlitau commented Sep 14, 2021

Fixes occasional fatal error: concurrent map iteration and map write

Fixes #111

@codecov-commenter
Copy link

Codecov Report

Merging #115 (c31e169) into master (741e560) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
+ Coverage   62.30%   62.40%   +0.11%     
==========================================
  Files          11       11              
  Lines         716      718       +2     
==========================================
+ Hits          446      448       +2     
  Misses        235      235              
  Partials       35       35              
Impacted Files Coverage Δ
attacker/metrics.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 997f655...c31e169. Read the comment docs.

Copy link
Owner

@nakabonne nakabonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for noticing the data race on the StatusCode and work on that!

@nakabonne nakabonne merged commit 7aa0ece into nakabonne:master Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fatal error: concurrent map iteration and map write
3 participants