-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tcell to support Windows #56
Conversation
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
- Coverage 77.75% 76.35% -1.39%
==========================================
Files 8 8
Lines 382 389 +7
==========================================
Hits 297 297
- Misses 66 73 +7
Partials 19 19
Continue to review full report at Codecov.
|
@markruler Hi, thanks for your contribution! To be honest, I've been putting off anything related to Windows for a long time. I'm not able to set up a Windows environment right away, so please be patient! (will probably start on it this weekend) |
@markruler We need to discuss this before implementing it, so could you please open a new issue with the screenshot? |
I just opened a new issue #62 |
Hi @markruler, Just used your branch with Powershell and it looks like this: Using cmd.exe inside Windows Terminal, redraw is quite slow (and I can see it "moving from upwards to the bottom"), but it actually works OK IMO: I'm using Windows terminal on 20231 pre_release (Insider fast build). Perhaps it's improved on new releases (like the build I'm using) but I'm not sure. I'm using Windows Terminal version 1.3.2651.0. Which release are you on? |
Thanks for your review! @brenol I think this is a problem that happened when I customized the terminal. But I still don't know exactly why this problem happened. |
I've figured out the cause. It's because of the font. @nakabonne |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that it may not render correctly with some font settings. It doesn't seem to be a problem, so I'll be happy to merge it.
@markruler Thanks for your help!
@brenol Thanks for helping me with my review! |
But it doesn't work properly. I need help with this PR.