Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tcell to support Windows #56

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Add tcell to support Windows #56

merged 1 commit into from
Oct 13, 2020

Conversation

markruler
Copy link
Contributor

image

image

But it doesn't work properly. I need help with this PR.

@codecov-io
Copy link

codecov-io commented Oct 8, 2020

Codecov Report

Merging #56 into master will decrease coverage by 1.40%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
- Coverage   77.75%   76.35%   -1.39%     
==========================================
  Files           8        8              
  Lines         382      389       +7     
==========================================
  Hits          297      297              
- Misses         66       73       +7     
  Partials       19       19              
Impacted Files Coverage Δ
gui/gui.go 63.64% <0.00%> (-9.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ece720d...d55656e. Read the comment docs.

@nakabonne
Copy link
Owner

@markruler Hi, thanks for your contribution! To be honest, I've been putting off anything related to Windows for a long time. I'm not able to set up a Windows environment right away, so please be patient! (will probably start on it this weekend)

@nakabonne
Copy link
Owner

@markruler We need to discuss this before implementing it, so could you please open a new issue with the screenshot?

@nakabonne nakabonne mentioned this pull request Oct 10, 2020
@nakabonne
Copy link
Owner

I just opened a new issue #62

@brenol
Copy link
Contributor

brenol commented Oct 12, 2020

Hi @markruler,

Just used your branch with Powershell and it looks like this:
image

Using cmd.exe inside Windows Terminal, redraw is quite slow (and I can see it "moving from upwards to the bottom"), but it actually works OK IMO:
image

I'm using Windows terminal on 20231 pre_release (Insider fast build).

Perhaps it's improved on new releases (like the build I'm using) but I'm not sure. I'm using Windows Terminal version 1.3.2651.0.

Which release are you on?

@markruler
Copy link
Contributor Author

Thanks for your review! @brenol
Yes, my terminal version is 1.3.2651.0. And I tried to install Windows 10 on the Hyper-V, but there was nothing wrong.

image

I think this is a problem that happened when I customized the terminal. But I still don't know exactly why this problem happened.

@markruler
Copy link
Contributor Author

I've figured out the cause. It's because of the font.

@nakabonne
Could you merge this PR?

image

Copy link
Owner

@nakabonne nakabonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that it may not render correctly with some font settings. It doesn't seem to be a problem, so I'll be happy to merge it.

@markruler Thanks for your help!

@nakabonne nakabonne merged commit 4ebe364 into nakabonne:master Oct 13, 2020
@nakabonne
Copy link
Owner

@brenol Thanks for helping me with my review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants