Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for resolvers option #87

Merged
merged 6 commits into from
Dec 5, 2020

Conversation

matsuyoshi30
Copy link
Contributor

@matsuyoshi30 matsuyoshi30 commented Nov 23, 2020

Closes #85

@matsuyoshi30 matsuyoshi30 marked this pull request as draft November 23, 2020 15:04
@codecov-io
Copy link

codecov-io commented Nov 23, 2020

Codecov Report

Merging #87 (a715d46) into master (04b67c9) will increase coverage by 0.05%.
The diff coverage is 63.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
+ Coverage   71.62%   71.66%   +0.05%     
==========================================
  Files           8        8              
  Lines         546      568      +22     
==========================================
+ Hits          391      407      +16     
- Misses        125      127       +2     
- Partials       30       34       +4     
Impacted Files Coverage Δ
attacker/attacker.go 68.63% <ø> (ø)
main.go 73.29% <63.64%> (-1.71%) ⬇️
gui/drawer.go 74.02% <0.00%> (+1.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04b67c9...a715d46. Read the comment docs.

@matsuyoshi30 matsuyoshi30 changed the title WIP: Add support for resolvers option #85 WIP: Add support for resolvers option Nov 24, 2020
@matsuyoshi30 matsuyoshi30 changed the title WIP: Add support for resolvers option Add support for resolvers option Nov 25, 2020
@matsuyoshi30 matsuyoshi30 marked this pull request as ready for review November 25, 2020 14:51
@nakabonne
Copy link
Owner

@matsuyoshi30 Hi, thanks for your contribution! I'll take a look later 😄

@nakabonne
Copy link
Owner

Sorry for the delay. I'm in the middle of something, so I'll take a look this weekend.

Copy link
Owner

@nakabonne nakabonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the well-tested patch! Looks pretty neat :D

@nakabonne nakabonne merged commit 057c16c into nakabonne:master Dec 5, 2020
@matsuyoshi30
Copy link
Contributor Author

Thanks for great opportunity 👍

@matsuyoshi30 matsuyoshi30 deleted the feature/add-dns-resolver branch December 5, 2020 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support resolvers option
3 participants