Fixing several misuses of private/public key pairs, other corrections #61
+19
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…used to encrypt messages for decryption by a public key- or anyone can decrypt it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Nakov!
I want to thank you for your incredible work putting together this guide. I thoroughly enjoyed reading it and will keep it bookmarked as a reference for all future projects I work on!
I am a ~10 year professional software engineer and in that time I have had the opportunity to gain a fair bit of experience and familiarity with cryptographic algorithms and best practices. Still, I learned some new things while reading these documents and I greatly appreciate that. I did happen to notice several errors while reading, and added a few extra details as well in some places I felt would benefit from them. I hope that you will allow me to contribute to your effort. I look forward to your review and will respond in kind to any comments!
turkycat