Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: get_notifications #68

Merged
merged 13 commits into from
Nov 13, 2022
Merged

Feature: get_notifications #68

merged 13 commits into from
Nov 13, 2022

Conversation

CloCkWeRX
Copy link
Contributor

Fixes #66

Probably want to squash merge this.

@CloCkWeRX CloCkWeRX mentioned this pull request Mar 20, 2022
Open
namaggarwal
namaggarwal approved these changes Nov 13, 2022
View reviewed changes
Copy link
Owner

@namaggarwal namaggarwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did update the updateExpense test in this, but overall it looks good. Thanks for your effort

@namaggarwal namaggarwal merged commit 2d4e748 into namaggarwal:master Nov 13, 2022
@CloCkWeRX CloCkWeRX deleted the feature/get_notifications branch November 14, 2022 10:38
@CloCkWeRX
Copy link
Contributor Author

Thank you for merging :) I'll dust off my home assistant stuff and see how this works

@CloCkWeRX CloCkWeRX mentioned this pull request Nov 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namaggarwal namaggarwal namaggarwal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for get_notifications
2 participants
@CloCkWeRX @namaggarwal