Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VirusTotal check doesn't support non-ASCII filenames #187

Closed
zinalili opened this issue Jul 24, 2023 · 2 comments
Closed

VirusTotal check doesn't support non-ASCII filenames #187

zinalili opened this issue Jul 24, 2023 · 2 comments

Comments

@zinalili
Copy link

Every time I click on VirusTotal icon, Windows Explorer restarts.
Windows 10 22H2
OpenHashTab 3.0.4.0

@namazso
Copy link
Owner

namazso commented Jul 24, 2023

Hm, works on my machine.

Can you reproduce it on the standalone version? Just export hashes, then double-click the file, that will open the standalone version.

If you can, then install procdump with procdump -i C:\my\dumps\folder -mt (with a path where you have write rights to) and get the standalone version to crash. A .dmp should appear in the folder, please send that to me by email. It is a triage level dump which should contain minimal personal information, but it will probably contain things like the file you're attempting to scan.

@namazso
Copy link
Owner

namazso commented Jul 24, 2023

Okay, I think I figured it out. This happens when formatting the query string fails, which occurs when the file name contains characters that cannot be represented in your system locale. In that case _vscprintf returns -1, and we try to resize the string to (size_t)-1 long, also known as 18446744073709551615. Of course that results in "string too long" exception, which is uncaught, resulting in a crash.

Additionally it is also subtly wrong for non-ASCII filenames that are representable in the current locale, as it produces invalid UTF-8 which VirusTotal will just reject with an error:

image

@namazso namazso changed the title VirusTotal check restarts Explorer VirusTotal check doesn't support non-ASCII filenames Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants