sendopenidempotent rpc method #18
Conversation
RevCBH
force-pushed
the
bennetthoffman/ch2462/sendopenidempotent-rpc-method
branch
from
c9fcf6a
to
977c661
Compare
lib/wallet/rpc.js
Outdated
| const tx = await wallet.sendOpen(opts.name, opts.force, { | ||
| account: opts.account, | ||
| idempotencyKey: opts.idempotencyKey | ||
| }); |
There was a problem hiding this comment.
Ahh yeah, the 'format on save' made the change set way bigger bc the codebase doesn't conform to whatever settings we use elsewhere.
There was a problem hiding this comment.
Yeah hsd uses different .eslint settings, I recall some weirdness setting it up on my machine but don't remember everything involved. I forget if you need to use "bslint" (bcoin's eslint with frozen deps) or not
lib/wallet/wallet.js
Outdated
| this.sendBidResults = new LRU(bidsCapacity); | ||
|
|
||
| // TODO (bennett) - make this configurable from options | ||
| const opensCapacity = 6500; // 300 opens * 20 + 1 blocks + 200 extra |
There was a problem hiding this comment.
Would prefer if the math were just coded in so we can change the parameters without needing to do the math ourselves (eg when we change 20 to 6)
lib/wallet/rpc.js
Outdated
| @@ -1,4 +1,4 @@ | |||
| /*! | |||
| 2015/*! | |||
There was a problem hiding this comment.
Did you do 2015G in vim and accidentally enter this lol
There was a problem hiding this comment.
Oh, no, it's actually that I tried to do 2015G in vscode because I was just in vim, instead of Ctrl+G 2015, which is correct
| this.sendBidResults = new LRU(bidsCapacity); | ||
|
|
||
| // TODO (bennett) - make this configurable from options | ||
| const opensCapacity = consensus.MAX_BLOCK_OPENS * opensCacheSizeInBlocks; |
There was a problem hiding this comment.
Variable not defined opensCacheSizeInBlocks
RevCBH
force-pushed
the
bennetthoffman/ch2462/sendopenidempotent-rpc-method
branch
from
119a9e3
to
d27ccd1
Compare
No description provided.