Support for clearing HSD caches #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbomaze
reviewed
Aug 27, 2020
lib/wallet/wallet.js
Outdated
| */ | ||
|
|
||
| clearCache(cacheName, cacheKey) { | ||
| var cache; |
lib/wallet/wallet.js
Outdated
|
|
||
| clearCache(cacheName, cacheKey) { | ||
| var cache; | ||
| switch(cacheName) { |
There was a problem hiding this comment.
style nit: switches in javascript are very error prone, missing some of the protections that languages like go give you, would prefer if/else if/else
lib/wallet/wallet.js
Outdated
| throw new Error(`invalid cache name: ${cacheName}`) | ||
| } | ||
|
|
||
| if (!cacheKey) { |
There was a problem hiding this comment.
doesn't matter at all given our keys, but as a general comment about this type of check since it may apply in other code in the future, would use an explicit undefined or null check here since the empty string is falsey but could be a valid key
There was a problem hiding this comment.
I was including the empty string in the set of desirably false-y keys, but can check for it explicitly.
RevCBH
force-pushed
the
bennetthoffman/ch2890/enable-cache-clearing-in-hsd
branch
from
138c0b7
to
874f06f
Compare
turbomaze
approved these changes
Aug 27, 2020
turbomaze
deleted the
bennetthoffman/ch2890/enable-cache-clearing-in-hsd
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.