Return an error response hsd-proxy can parse #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbomaze
approved these changes
Feb 23, 2021
| @@ -973,7 +977,7 @@ class HTTP extends Server { | |||
| return res.json(200, ns.getJSON(height, network)); | |||
| } | |||
|
|
|||
| return res.json(404, {success: true}); | |||
| return notFound(); | |||
There was a problem hiding this comment.
Why did this originally have success: true?
There was a problem hiding this comment.
It was just random JSON to parse, as far as I can tell. Nothing appears to expect that result, the only thing that calls it tries to extract a message field if the status code is non-200
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw a noisy error in honeycomb about not being able to parse an error response, this should fix it.
For reference, the error: https://ui.honeycomb.io/namebase/datasets/namebase-web/result/y5thSyxt1K9