Directory flag specifies maxdepth 1

[blimmer]

Today, pulling protofiles using the -d flag specifies a max-depth of 1.

docker-protoc/all/entrypoint.sh

Line 174 in 93b2381

PROTO_FILES=(`find ${PROTO_DIR} -maxdepth 1 -name "*.proto"`)

Is there a specific reason for this? Can it be configurable?

We have a directory structure that looks like this:

src/main/proto/company_pb
├── billing
│   └── events.proto
├── commons
│   ├── sqs
│   │   ├── sqs_attribute.proto
│   │   ├── sqs_attributes.proto
│   │   └── sqs_message.proto
│   └── timestamp.proto

So the maxdepth flag causes the command to fail out with this error

Missing input file.

because no files are passed to the underlying method.

[mhamrah]

There's no reason for this, except how we do it at namely. I'll try to throw something together, and PR's always welcome!

[blimmer]

I just tried it out locally by just removing the -maxdepth option and things worked swimmingly for me! I'm happy to do a PR to this project.

The biggest question I have is whether or not we need to maintain the old behavior by default, or if we're comfortable just removing the maxdepth option. I'm open to doing it either way. Thoughts?

[mhamrah]

Submit a PR and I can test- should be okay.

…

On Thu, Apr 19, 2018 at 3:48 PM Ben Limmer ***@***.***> wrote: I just tried it out locally by just removing the -maxdepth option and things worked swimmingly for me! I'm happy to do a PR to this project. The biggest question I have is whether or not we need to maintain the old behavior by default, or if we're comfortable just removing the maxdepth option. I'm open to doing it either way. Thoughts? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#61 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFkGgmFK4OqyqHh_bFXmjW77LKepm9bks5tqOoggaJpZM4TcEjv> .

[arturgspb]

If you like me in 2020+ don't understand why code with blocking max-depth come back - read #112