Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub: don't fail if a user has no SSH keys. #13

Merged
merged 2 commits into from
Jul 3, 2024
Merged

GitHub: don't fail if a user has no SSH keys. #13

merged 2 commits into from
Jul 3, 2024

Conversation

attilaolah
Copy link

No description provided.

@attilaolah
Copy link
Author

I think this still doesn't work, I get the same error when trying the action from this branch.

Don't merge yet.

@attilaolah
GitHub: don't fail if a user has no SSH keys, take #2.
9bdd00e 
This works around the fact that strings.Split() will never return an empty slice.
@attilaolah
Copy link
Author

OK it is working now. The issue was that strings.Split("", "\n") returns []string{""}, but we want an empty slice. strings.FieldsFunc can do that better.

@attilaolah attilaolah merged commit 6eece93 into main Jul 3, 2024
1 check passed
@attilaolah attilaolah deleted the attila/nsl-3526-breakpoint-functionality-is-not-working-properly-and-there branch July 3, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavolmarko pavolmarko pavolmarko approved these changes

@hugosantos hugosantos hugosantos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@attilaolah @hugosantos @pavolmarko