Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECDSA signing/verification issues #43

Closed
lcobucci opened this issue Sep 4, 2015 · 9 comments
Closed

ECDSA signing/verification issues #43

lcobucci opened this issue Sep 4, 2015 · 9 comments

Comments

@lcobucci
Copy link

lcobucci commented Sep 4, 2015

Hello guys, @jurriaan opened an issue in my library to notify that the I have some problems with my ECDSA signer.

Looking at your code I saw that you're basically doing the same thing as I, but you have another issue: you're ignoring openssl_verify() return by casting it bool. It's returning -1 (error) and if you run openssl_error_string() you'll get error:0906D06C:PEM routines:PEM_read_bio:no start line as return.

You can have more information in lcobucci/jwt#30.
I'm working on a solution for that and I'll share with you guys 😄

@odino
Copy link
Contributor

odino commented Sep 6, 2015

perfect, waiting for a PR then :)

@jurriaan
Copy link

jurriaan commented Sep 6, 2015

See jwt/ruby-jwt#87 for how I fixed it in ruby-jwt :)

@lcobucci
Copy link
Author

@odino I've finished implementation.
I had to rewrite everything since OpenSSL doesn't supports NIST curves.

You can see the related commits and apply the same thing here ;)

@fproject
Copy link

Dear all
How about the status now?

@odino
Copy link
Contributor

odino commented Sep 26, 2015

@lcobucci do you have a link to the changeset?

@lcobucci
Copy link
Author

@odino sorry about my delay. Check here: lcobucci/jwt@f787525

@odino
Copy link
Contributor

odino commented Sep 29, 2015

thanks!

@cirpo
Copy link
Contributor

cirpo commented Dec 9, 2015

theopenssl_verify() casting issue is solved and merged: #58

@GrahamCampbell
Copy link
Contributor

Can this be closed then?

@odino odino closed this as completed Dec 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants