A few fixes to support phpseclib 2

[kasparasg]

@cirpo Wondered if this dependency could be upgraded? I feel like I fixed the broken bits and the tests pass 😉

Thanks.

[cirpo]

@foreachlt thanks, I'll give it a look this week. I'm a little bit worried and we should triple check because probably there are some cases not covered by tests (we already tried once).

[kasparasg]

@cirpo thank you for taking a look at this 👍

[tristanbes]

we're really looking towards this merge/fix (too) because without this, we can't use google api client in version 2 because it requires phpseclib2 which conflicts with your library. Thanks for fixing it @foreachlt

[cirpo]

@foreachlt could you please rebase this PR with the latest master? We've just released version 6.0.4.
thanks

[kasparasg]

@cirpo will do 😉

[cirpo]

@foreachlt if you could use php-cs-fixer with --level=symfony --fixers=ordered_use it would be awesome :)

[kasparasg]

@cirpo it should be all done 👍

[kasparasg]

@cirpo ohh, will apply php fixer stuff too, just a sec

[cirpo]

@foreachlt @tristanbes I will try to make it by the end of this week, thanks a lot guys!

[kasparasg]

@cirpo php-cs-fixer hasn't found any violations in src/ dir 😉

[cirpo]

@foreachlt 👍

[tristanbes]

@cirpo what prevents this PR to be merged and tag a release right now if all the tests pass? I'm curious.

[cirpo]

@tristanbes last time the tests where passing but someone experienced some issues. We need to check the coverage. I can't do it right now as I'm a bit busy and I would avoid the same mistake we did last time.
If you desperately need it you can point your composer.json to https://github.com/foreachlt/jose
It's just a matter of precaution and time :)
I'll try to do it as soon as possible, I promise :)

[tristanbes]

ok thanks for your answser :)

[cirpo]

@foreachlt I created a new branch phpseclib-2 https://github.com/namshi/jose/tree/phpseclib-2. Could you please open the PR against that branch? I will be easy for everyone to test it, wdyt?

[cirpo]

@foreachlt @tristanbes everything seems working fine on our side.

@foreachlt you get phpseclib ~2.0 the 2.0-dev version, what if we specify the 2.0.0? what are your thoughts about it?

[kasparasg]

@cirpo sure, I agree with you. I didn't realize it would get 2.0-dev. What do you think about 2.0.* in order to accept minor patches by default? Provided that semver is used correctly by phpseclib-2.

[tristanbes]

👍 for 2.0.*

[cirpo]

@foreachlt if you want you can do the modification :)
I will merge it and create the 6.1.0 tag

[kasparasg]

@cirpo changed the version. Rebased, tests still pass locally. All good to I think 😉

[cirpo]

yalla, lets merge!

[cirpo]

@foreachlt @tristanbes enjoy the 6.1.0 release

thanks a lot folks!