Fix: Fix broken indexing – only first two text chunks are indexed #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Klingefjord
changed the title
namuan
approved these changes
Jan 29, 2023
|
Thanks. It is merged and should be available in 1.5.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Awesome library, but it it has a pretty serious bug:
docsearch.from_texts(...)doesn't actually add anything to the vectorstore, it only returns a new vectorstore. This means that currently, only the first two text chunks have their indices saved.Changing to .add_texts() fixes this. No need to pass the OpenAIEmbeddings as it is saved in the instance.