Email templates #74
Email templates #74
Conversation
|
|
||
| <p>If you didn't request this, please ignore this email.</p> | ||
| <p>Your password won't change until you access the link above and create a new one.</p> | ||
| <h2>Hey there!</h2> |
There was a problem hiding this comment.
what do you think about having "Forgot your password?" as the header for this one? strange to have the same "Hey there!" for both welcome email and forgot your password email
|
Strange, why don't the buttons in the screenshots have green backgrounds and white text? |
|
I couldn't figure out why either. Also agreed UserMailer is fine. |
aktwo
force-pushed
the
email_templates
branch
from
3687c1e
to
1deb0a4
Compare
|
So I figured out why I thought I broke it yesterday... I was running the server while still rebasing the git history, and I hadn't added |
|
can we figure out how to make the buttons look like buttons? (filled in with green, white text) we should find out why the css styles are not being applied anyway b/c unpredictable behavior is concerning |
| <p>Your password won't change until you access the link above and create a new one.</p> | ||
| <h2>Hey there!</h2> | ||
| <p>Forgot your password? No problem.</p> | ||
| <p><%= link_to 'Reset my password', edit_password_url(@resource, reset_password_token: @token), class: "btn btn-lg btn-success" %></p> |
There was a problem hiding this comment.
how about "Reset my password" -> "Reset Password"?
(capitalizing first character of each word and dropping "my")
aktwo
force-pushed
the
email_templates
branch
from
1deb0a4
to
5ffa647
Compare
|
Fixed the issue by using a static image of a button hosted on an external server. I only used an external server because there is a known issue with Roadie serving local image files (Mange/roadie-rails#10). I could have monkey-patched it, but I figured this was a cleaner solution just to get the product launched. |
aktwo
force-pushed
the
email_templates
branch
2 times, most recently
from
3e6cbb1
to
6f0d19b
Compare
|
if we're using images as buttons, why not get rid of roadie entirely? the whole problem it solves is making lots of css manageable for emails but it seems that we don't include much css at this point |
Resolves #52
Confirmation email (both plaintext, html in-browser and html in Apple Mail)
Reset password email (both plaintext, html in-browser and html in Apple Mail)