Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update leftover hardcoded colors in the scss template to be template values #216

Closed
actionless opened this issue Mar 19, 2018 · 1 comment
Assignees

Comments

@actionless
Copy link
Collaborator

hi, in your latest fix you've added to the template tooltip with color $grey_800

however in that template there are couple of more hardcoded color values, you can assign this issue to me (i am a bit busy right now, so creating ticket not to forget about it)

@nana-4
Copy link
Owner

nana-4 commented Mar 20, 2018

Hi, thanks for the ticket and PR!

I intentionally hard-coded $tooltip_bg_color because if both %MENU_BG% and %SEL_FG% are defined with blighter colors, tooltip's text color will be almost invisible. But I decided to merge your PR and add $tooltip_fg_color: %MENU_FG%; to deal with it.

Thanks again for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants