feat(new): supports custom and without icon #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nandorojo
reviewed
Mar 2, 2023
ios/BurntModule.swift
Outdated
| if(options.preset == .none){ | ||
| view = SPIndicatorView(title: options.title, message: options.message) | ||
| } else if(options.preset == .custom){ | ||
| view = SPIndicatorView(title: options.title, message: options.message, preset: options.preset.toSPIndicatorPreset(options)!) |
There was a problem hiding this comment.
I believe it's better to unwrap if the values with if let the way I did previously, instead of asserting with !.
There was a problem hiding this comment.
I just noticed that it has only two ways to init it, so I just sorted out the code style, I think this commit will be good!
nandorojo
reviewed
Mar 2, 2023
|
also, we need to handle a case when the icon is not found, so I just committed this to catch some edge case. CleanShot.2023-03-03.at.5.21.30.mp4 |
nandorojo
reviewed
Mar 3, 2023
nandorojo
reviewed
Mar 3, 2023
nandorojo
reviewed
Mar 3, 2023
nandorojo
reviewed
Mar 3, 2023
nandorojo
reviewed
Mar 3, 2023
|
Left some extra notes @alantoa. I think the |
|
Is it all tested & good to go? |
|
@nandorojo yeah sure, I'm already using the patch file now! |
|
Published at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
burnt has not supported some features below:
erroranddoneicon.so I made this PR to support them.
How
update some ts type and improve the
BurntModule.swiftnative module.Test
CleanShot.2023-03-03.at.2.31.39.mp4