Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible miscalculation #1

Closed
michalfilippi opened this issue Apr 23, 2017 · 4 comments
Closed

Possible miscalculation #1

michalfilippi opened this issue Apr 23, 2017 · 4 comments

Comments

@michalfilippi
Copy link

Hi,
I was implementing SOV score calculator as well and I tried to compare my results with yours (as a sort of back check) and I found out they differ. So I dug deeper and I think there might be some error in your calculation.

For example, according to original article1 about SOV score, for observation RREEERRRRRREEEEEERRR and prediction RRRRRRREEEEERRREERRR the calculated SOV score should be equal 39.4. But your program returns 42.56.

I haven't tried to look for the exact code section causing this.

Have a good day and thank you for publishing your code. :) It helped me.

Michal

[1] : A Zemla, C Venclovas, K Fidelis, and B Rost. A modified definition of sov, a segment-based measure for protein secondary structure prediction assessment. Proteins, 34(2):220–3, 1999.

@mircare
Copy link

mircare commented Aug 31, 2018

Hi,

I have just noticed that your SOV score sometimes differs from http://proteinmodel.org/AS2TS/SOV/sov.html -- e.g., http://as2ts.proteinmodel.org/AS2TS/DATA/JOBS/job_85611_180831_13r/SOV_85611.html -- and http://dna.cs.miami.edu/SOV/.

Best,
Mirko

@nanjiangshu
Copy link
Owner

nanjiangshu commented Aug 31, 2018 via email

@nanjiangshu
Copy link
Owner

nanjiangshu commented Aug 31, 2018 via email

@nanjiangshu
Copy link
Owner

Hi @mircare. I've rewrote the function for CalSOV() and now it returns the same result as in http://proteinmodel.org/AS2TS/SOV/sov.cgi. It is fun to write the code in c++ again although I have moved to the Python world many years ago :)

Best,

Nanjiang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants