Don't update model in LoopMode::Wait when there were no events #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @zgotsch, looks good to me! |
mitchmindtree
added a commit
to mitchmindtree/nannou
that referenced
this pull request
Dec 14, 2021
After landing nannou-org#782 I noticed that the `App` proxy's `wakeup` method hasn't been functional since the last event loop refactor (when wgpu was introduced). I also noticed that nannou-org#782 makes the extra updates provided in the `Wait` loop mode redundant. Previously, we ensured at least ~3 updates would occur following the most recently received event. This was aimed at allowing GUI's to update for a couple of extra frames to resolve subtle 1-3 frame animations, but I'm unsure this is really the right approach. At the very least, the number of updates should be configurable as a part of the `LoopMode::Wait` variant, but that can wait for a future PR.
This was referenced Dec 14, 2021
mitchmindtree
added a commit
that referenced
this pull request
Dec 17, 2021
After landing #782 I noticed that the `App` proxy's `wakeup` method hasn't been functional since the last event loop refactor (when wgpu was introduced). I also noticed that #782 makes the extra updates provided in the `Wait` loop mode redundant. Previously, we ensured at least ~3 updates would occur following the most recently received event. This was aimed at allowing GUI's to update for a couple of extra frames to resolve subtle 1-3 frame animations, but I'm unsure this is really the right approach. At the very least, the number of updates should be configurable as a part of the `LoopMode::Wait` variant, but that can wait for a future PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending some clarity from the
winitmaintainers about whether wait interruptions without events are allowed, this is an idea for a fix forLoopMode::Waitif they are.See rust-windowing/winit#1985 for more info.
Fixes #781