Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HatchSvg Refactoring: Pattern creation #6

Closed
Tracked by #1
mme1950 opened this issue Nov 13, 2023 · 1 comment
Closed
Tracked by #1

HatchSvg Refactoring: Pattern creation #6

mme1950 opened this issue Nov 13, 2023 · 1 comment
Assignees
@mme1950

Comments

@mme1950
Copy link
Contributor

mme1950 commented Nov 13, 2023

  • Pattern creation must be called in the HatchSvg constructor, dedicated method to create pattern.
  • Create the pattern in the PatternSvg class.
@mme1950 mme1950 mentioned this issue Nov 13, 2023
Closed
8 tasks
@mme1950
Copy link
Contributor Author

mme1950 commented Nov 13, 2023 •
edited
Loading

Patterns are created in the constructor pf the PatternSvg class.
ToSvgElement() creates a PatternElement

TODO: #7 how to apply rotation, color->stroke or fill for each hatch independetly.

mme1950 added a commit that referenced this issue Nov 13, 2023
@mme1950
#6 Hatch/Pattern
b424b78 
-  Pattern creation called in HatchSvg constructor
-  Pattern cretion in PatternSvg
-  Concrete Pattern improved

Still TODO Pattern Color and Rotation are proprties of Hatch and should not be set as pttern attributes
@mme1950 mme1950 self-assigned this Nov 19, 2023
@mme1950 mme1950 closed this as completed Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mme1950 mme1950

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mme1950