Skip to content
This repository has been archived by the owner on Oct 16, 2020. It is now read-only.

Fix handing of $empty and add mapping for $mp4 #8

Closed
jspenguin2017 opened this issue Dec 8, 2017 · 3 comments
Closed

Fix handing of $empty and add mapping for $mp4 #8

jspenguin2017 opened this issue Dec 8, 2017 · 3 comments
Labels
archived This thread was archived, open new issues for similar problems. fixed
Milestone
v1.0.1

Comments

@jspenguin2017
Copy link
Member

jspenguin2017 commented Dec 8, 2017 •
edited
Loading

Adguard's $empty should "emulate a blank response", which means a noop redirect with the proper type. Currently it is treated like normal network filter. Either stop parsing it or fix it.

Adguard's $mp4 should be mapped to $media,redirect=nano-noopmp4-1s. Need to add the resource first.
@jspenguin2017 jspenguin2017 modified the milestones: v1.0.2, v1.0.3 Dec 8, 2017
@jspenguin2017
Copy link
Member Author

This can cause some incompatibility with upstream, need to reconsider.

@jspenguin2017 jspenguin2017 removed this from the v1.0.3 milestone Dec 16, 2017
@jspenguin2017
Copy link
Member Author

Forget about incompatibility, I'll change it in a way that I believe to be right.

@jspenguin2017 jspenguin2017 added this to the v1.0.1 milestone Dec 29, 2017
@jspenguin2017
Copy link
Member Author

Landed in 1.0.0.22

@github-actions github-actions bot added the archived This thread was archived, open new issues for similar problems. label Aug 21, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
archived This thread was archived, open new issues for similar problems. fixed
Projects
None yet
Milestone
v1.0.1
Development

No branches or pull requests
1 participant
@jspenguin2017