Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes the accounts_representatives RPC to return per account response #3789

Merged
merged 2 commits into from
Apr 14, 2022

Conversation

thsfs
Copy link
Contributor

@thsfs thsfs commented Apr 13, 2022

The previous implementation returned only an error result in case any of the provided accounts were invalid or not found. This implementation handles each account separately returning either a successful or an error response.

Example:

    "representatives": {
        "nano_3wfddg7a1paogrcwi3yhwnaerboukbr7rs3z3ino5toyq3yyhimo6f6egij6": "nano_3wfddg7a1paogrcwi3yhwnaerboukbr7rs3z3ino5toyq3yyhimo6f6egij6",
        "nano_36uccgpjzhjsdbj44wm1y5hyz8gefx3wjpp1jircxt84nopxkxti5bzq1rnz": "error: Bad account number",
        "nano_1hrts7hcoozxccnffoq9hqhngnn9jz783usapejm57ejtqcyz9dpso1bibuy": "error: Account not found"
    }

Reference issue: #3752

@thsfs thsfs requested a review from zhyatt April 13, 2022 01:39
@thsfs thsfs added the rpc Changes related to Remote Procedure Calls label Apr 13, 2022
@thsfs thsfs added this to the V24.0 milestone Apr 13, 2022
@thsfs thsfs force-pushed the accounts_representatives_per_item_response branch from 8cb7a8d to 0e235a9 Compare April 13, 2022 14:39
@thsfs thsfs requested a review from clemahieu April 13, 2022 16:54
@nanocurrency nanocurrency deleted a comment from clemahieu Apr 14, 2022
@thsfs thsfs force-pushed the accounts_representatives_per_item_response branch from 0e235a9 to f86622f Compare April 14, 2022 18:08
@thsfs thsfs requested a review from dsiganos April 14, 2022 18:09
@thsfs thsfs merged commit ba83c03 into develop Apr 14, 2022
@thsfs thsfs deleted the accounts_representatives_per_item_response branch April 14, 2022 19:19
@thsfs thsfs assigned thsfs and unassigned thsfs Jan 19, 2023
@thsfs thsfs added the documentation This item indicates the need for or supplies updated or expanded documentation label Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This item indicates the need for or supplies updated or expanded documentation rpc Changes related to Remote Procedure Calls
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants