Optimize election scheduler activate function #4636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ledger set height(account) overload." This reverts commit 9512140. # Conflicts: # nano/node/backlog_population.cpp # nano/node/node.cpp
pwojcikdev
force-pushed
the
revert-activate-develop
branch
from
28dd829
to
9702ecd
Compare
clemahieu
previously approved these changes
May 22, 2024
|
I eliminated one additional database lookup, please have a second look @clemahieu |
pwojcikdev
force-pushed
the
revert-activate-develop
branch
from
1848051
to
2fb1aff
Compare
clemahieu
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts some of the changes made during refactoring to block sets. The new versions were doing many redundant database lookups, which started to become a bottleneck.