Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust SPIFFs object length in IDF sdkconfigs #2571

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Feb 16, 2023

Description

  • SPIFFs object length is now 256 on all SDKCONFIG for all versions.
  • Also had to adjust CONFIG_SPIFFS_PAGE_SIZE to pass the internal validation because of the increased size.

Motivation and Context

  • Aligns this with the other platforms were SPIFFS is being used. 32 is too short for the average use.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dev Containers (changes related with Dev Containers, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).

@josesimoes josesimoes added the Platform: ESP32 Everything related specifically with ESP32 platform label Feb 16, 2023
- Also had to adjust CONFIG_SPIFFS_PAGE_SIZE to pass the internal validation.
@josesimoes josesimoes merged commit fa1b806 into nanoframework:main Feb 16, 2023
@josesimoes josesimoes deleted the fix-idf-sppifs branch February 16, 2023 11:57
@josesimoes josesimoes mentioned this pull request Feb 20, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: ESP32 Everything related specifically with ESP32 platform Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants